feat(files_sharing): import the sharing dialog directly - #64125
Merged
Conversation
skjnldsv
marked this pull request as ready for review
September 8, 2026 14:56
skjnldsv
requested review from
Altahrim,
kristian-zendato,
leftybournes,
provokateurin,
sorbaugh and
susnux
and
a lite review from Copilot
and removed request for
a team and
Copilot
September 8, 2026 14:56
susnux
approved these changes
Sep 8, 2026
skjnldsv
force-pushed
the
feat/sharing-dialog-direct-import
branch
2 times, most recently
from
September 10, 2026 07:25
695479c to
3c07f2d
Compare
The dialog is a Vue 3 component and this frontend is Vue 2, which is why it was reached through a bridge: a separate Vue 3 entry point registered it on `OCA.Sharing`, and the sidebar called through that global. @nextcloud/sharing 1.0.0-beta.3 declares Vue as a dependency rather than a peer, so npm installs its own copy next to it and the dialog runs on that one, the same way @nextcloud/dialogs already does. The sidebar imports the library directly and the bridge goes away: its entry point, the app symlink into the Vue 3 frontend, and the script and style that loaded it. That symlink was also what pulled this Vue 2 app through the Vue 3 lint and test configs, so the exclusions added for it are no longer needed. Signed-off-by: Barthelemy Briand <barthelemy.briand@nextcloud.com> Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
feat/sharing-dialog-direct-import
branch
from
September 10, 2026 07:42
3c07f2d to
62fcfa7
Compare
Member
Author
|
/backport! to stable35 please |
AndyScherzinger
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
susnux pointed out on #62593 that a Vue 3 library can run inside a Vue 2 app if it brings its own Vue, so the
OCA.Sharingbridge the sidebar used to reach the dialog through is unnecessary.@nextcloud/sharing1.0.0-beta.3 declaresvueand@nextcloud/vueas dependencies instead of peers, and this drops the bridge, its Vue 3 entry point, the app symlink into the Vue 3 frontend, and the script and style that loaded it.npm nests the library's own Vue in the legacy frontend, and its webpack config sets no
vuealias to override that:The symlink was also what pulled this Vue 2 app through the Vue 3 lint and Vitest configs, so I reverted the exclusions I added for it —
npm run lintis 0 errors without them.Unit tests and lint pass; the sharing end-to-end suite reached 22 of 35 with no failures before I stopped it, so it still needs a full run.
TODO
npx playwright test --project=sharing)Checklist
3. to review, feature component)stable32)AI (if applicable)